Just a NIT or three...
1293: There's no need to pass check_result if the value is just
Popen.SUCCESS. That's the default value.
1322: Your comment has a space after the comma but you're joining on
just ',' Can you update the comment?
1325, 1327: Combine this into a single return:
return ','.join(['"%s"' % domain for domain in search_domains])
(I'm not sure if that's longer than you have space. If it is, go back
to using 'x')
-Drew
On 2/10/12 8:22 PM, sanjay nadkarni wrote:
Could I get a few eyeballs for this simple fix.
https://cr.opensolaris.org/action/browse/caiman/nadkarni/dhcp/webrev/
Thanks
-Sanjay
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
