Tomas, I had expected this would be involve updating validate_login
somehow, as that also applies to the GUI. This fix would seem to make
the GUI and text installers inconsistent in what logins they would
accept, wouldn't it?
Dave
On 02/15/12 07:32, Tomas Dzik wrote:
Hi Dave and others,
I would like to ask you for a code review.
I reworked my fix and new webrev is here:
https://cr.opensolaris.org/action/browse/caiman/t.dzik/7097083-1/
Testing:
1) Source is pep8 clean
2) I run test suite which is part of the gate
3) I run manually sysconfig create-profile and verified which users
are/are not allowed.
4) I built text-install iso image using distro constructor and used this
iso image to install system on VirtualBox. I verified that sysconfig
allows/denies usernames as expected.
Thanks,
Tomas D.
Dne 13.02.12 23:54, Dave Miner napsal(a):
Tomas, I'm not sure I'm comfortable with this fix.
A list of special users off in this utility leads to the likelihood that
we'll have bugs as new "system" accounts are added to the product by
assorted packages and the suppliers of those accounts are unaware of
sysconfig's list. It's not clear to me that the problem in this bug is
serious enough to justify that extra maintenance.
What about making the validate_login() function more discriminating, so
that it can tell the UI whether a conflicting account that exists is a
system account (and hence likely a problem) or just an ordinary user
account that may or may not exist, and having the UI be able to provide
warnings rather than outright errors?
Dave
On 02/13/12 04:40, Tomas Dzik wrote:
Hi all,
I would like to ask you for code review for:
7097083 - sysconfig create-profile -o file.xml does not allow a user to
be created that is local
Webrev:
https://cr.opensolaris.org/action/browse/caiman/t.dzik/7097083/
Testing:
1) Source is pep8 clean
2) I run test suite which is part of the gate
3) I run manually sysconfig create-profile and verified which users
are/are not allowed.
Thanks,
Tomas D.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
