Hi Drew
Thanks for the review.
On 02/20/12 23:44, Drew Fisher wrote:
Nirmal,
The code review looks good to me. One thing though: did you test setting
up a disk with UFS slices as the bug explained?
If you set up the disk so that slice 0 has been newfs'd, and re-run
target discovery (auto-install -i -m manifest.xml) can you see your new
error messages in the log file? Does target discovery succeed?
I tested with UFS slices mentioned in the bug and checked the
install_log for "SliceInUseError". Also, target discovery succeeded in
the end.
Regards
Nirmal
-Drew
On 2/20/12 11:00 AM, Nirmal Agarwal wrote:
Hi all
Could I please get a code review for the following CR:
7143082 In Solaris11 AI, specifying <disk whole_disk="true"> in
ai_manifest will not wipe out disk
Webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7143082/
-- Source is pep8 clean.
slim_test result
----------------
/net/indiana-build.us.oracle.com//export/home/na210770/ai/7143082/slim_test
Manual Tests :
-- created a custom image and tested the fix with the manifest using
<disk whole_disk="true"> tag. AI install succeeds.
Let me know if I need to run some other tests.
Thanks
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
