Sue:

My comment are just nits:

Since you are updating delete_service.py, can you update to remove the following line to make pylint audit happy:

import  osol_install.libaiscf  as  libaiscf





On 03/12/12 11:09, Sue Sohn wrote:
Can I get a code review of the changes for:

7153092 appending slash to servicename when deleting an aliased service deletes service, but not alias

Webrev:
https://cr.opensolaris.org/action/browse/caiman/sohn/7153092/webrev.7153092

Testing:
Verified that delete-service rejects invalid service names, but continues to accept valid ones.
Added new unit test for delete_service.

Thanks,
Sue

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to