Mary,
LGTM.
-Drew
On 3/12/12 6:51 PM, Mary Ding wrote:
Hi:
I will like to ask for a code review for:
7094356 - Error message size units need correcting when disk to small
for text-install
http://monaco.us.oracle.com/detail.jsf?cr=7094356
Webrev is here:
https://cr.opensolaris.org/action/browse/caiman/md5645/7094356
I had fixed the display message and also do some pylint cleanup.
Testing:
1. I ran the slim_install_unit test and there is no failure. Results
is here:
/net/osol-bldx/datapool/ding/7094356/slim_source/test_results_1
2.
I used DC to build Text Install iso for testing purpose.
Before the fix, if you do any TI install, you will see the following
message in the install_log:
root@line3-t42:/system/volatile# grep gbMB install*log
2012-03-13 11:41:00,017 InstallationLogger INFO Installation
Device Size: 279.38gbMB
root@line3-t42:/system/volatile#
After the fix, the MB error is gone as follow:
root@line3-t42:/var/sadm/system/logs# grep gbMB in*log
root@line3-t42:/var/sadm/system/logs# grep gb in*log
2012-03-13 12:30:00,014 InstallationLogger INFO Installation
Device Size: 279.38gb
2012-03-13 12:30:00,014 InstallationLogger INFO Minimum
required size: 2.43gb
2012-03-13 12:30:00,014 InstallationLogger INFO Recommended
size: 4.43gb
2012-03-13 12:30:00,015 InstallationLogger INFO Swap size: 4.00gb
2012-03-13 12:30:00,016 InstallationLogger INFO Dump size:
63.75gb
root@line3-t42:/var/sadm/system/logs#
1. x86 TI CD - confirm the Installation Device Size display is correct.
2. sparc TI - confirm Installation Device Size display is correct.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
