I hope that I am not bringing up a subject that I shouldn't but it would
be helpful for people making code changes and those reviewing changes to
have a best practices/coding standards document. I reviewed Nirmal's
code and don't necessarily see a problem with how he did it but don't
know what we should be looking for other than functional
correctness/completeness. Do we already have a document like that or
any interest in creating one? I wouldn't mind acting as the POC and
creating a WIKI if there is interest.
Harold
On 03/15/12 12:01 PM, Jack Schwartz wrote:
Hi Nirmal.
Thanks for taking this bug.
In order to be consistent with the way other messages are done in this
module, I'd rather see the string of 178-179 done similar to the
following:
"AIM_LOGFILE I/O Error(%(errno)s) : %(strerror)s"
": %(fname)s" % ({"errno": errno, "strerror": strerror,
""fname": logfile_name})
Thanks,
Jack
On 03/14/12 01:21 AM, Nirmal Agarwal wrote:
Hi all
Can I please get a code review for CR 7142286.
7142286 aimanifest generates stack trace if environemnt variables are
set to directory instead of a file
Webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7142286/webrev/
Source is pep8 clean.
Tests :
--> Set the AIM_LOGFILE=/somedir and run aimanifest
root@vbox:~# aimanifest
AIM_LOGFILE I/O Error(21) : Is a directory
--> Set the AIM_LOGFILE=/etc and run as non root user.
vbox@vbox:~$ aimanifest
AIM_LOGFILE I/O Error(13) : Permission denied
Thanks
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
