Harold, Looks good to me too.
John Sent from my iPad On Apr 10, 2012, at 4:00 PM, Drew Fisher <[email protected]> wrote: > LGTM! > > -Drew > > On 4/10/12 4:46 PM, Harold Shaw wrote: >> >> Can I get a followup code review on this fix? It includes the following >> changes: >> >>> - Should image_type() be decorated with @property? >>> 85 def image_type(self): >> The unit tests have been updated to include a couple of tests for the new >> image_type property. Also the CR, 7160487 'installadm test suite should >> include test for fix of 7131425' was filed. >> >> Webrev: https://cr.opensolaris.org/action/browse/caiman/hshaw/7149189_1 >> >> Re-testing: >> still pep8 clean >> installadm image unit tests run >> attempt to create AI service from: >> - text UI & live CD created with DC changes (error out) >> - S11U1 text UI & live CD ISO's (from nana) (error out) >> - AI ISO created with DC changes (successful) >> >> Thanks, >> Harold >> >> On 03/20/12 15:34, Harold Shaw wrote: >>> >>> >>> Can I get a code review for the following bug: >>> >>> CR: http://monaco.sfbay/detail.jsf?cr=7149189 >>> >>> Webrev: https://cr.opensolaris.org/action/browse/caiman/hshaw/7149189 >>> >>> Testing: >>> pep8 clean >>> distro_const checkpoint unit tests have been run >>> Attempt to create an AI service from: >>> - text UI & live CD created with DC changes (error out) >>> - S11U1_11 text UI & live CD ISO's (from nana) (error out) >>> - AI ISO created with DC changes (successful) >>> Verified that the .image_info file contains the expected IMAGE_TYPE line >>> - S11U1_11 AI ISO (from nana) (successful) >>> >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >> >> >> _______________________________________________ >> caiman-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
