Jack:
Thanks for your comments.
On 04/12/12 08:35 AM, Jack Schwartz wrote:
Hi Mary.
Thanks for doing this. Here are some comments:
usr/src/README:
126: What are the first and second tools if this is the third tool?
I fixed it now and we just need to install pep8.
131: This is really not a separate item. It is a result of doing (3),
so I suggest removing "4."
Fixed.
133: This becomes item 4 now.
Fixed.
usr/src/tools/tests/README:
76: We're talking about running bldenv, not slim_test at this point.
(i.e. line 78 is running bldenv). But....
Fixed.
78: How come setting the environment needs to be run with sudo? The
environment should be settable as a normal user, and will be inherited
by subprocesses later.
From my notes with Keith, we need to run slim_test with root
priviledges. So setting the environment with sudo will automatically
get you root priviledge.
Thanks,
Jack
On 04/11/12 02:00 PM, Mary Ding wrote:
Hi:
Can I get a quick review for the following CR to update
usr/src/README and usr/src/tools/tests/README:
7144255 <http://monaco.us.oracle.com/detail.jsf?cr=7144255> Need to
update usr/src/tools/tests/README and usr/src/README about http
proxy/nosexunit/pylint/nose
The webrev is here:
https://cr.opensolaris.org/action/browse/caiman/md5645/7144255
Testing had been done as follow:
1. I installed nose 1.0.0 on tcu27-01 and install_unit_tests had no
failures:
http://indiana-build.us.oracle.com/job/install_unit_tests/810/testReport/
2. Installed nose 1.0.0 on osol-bldsp and install_unit_tests had no
new additional failures. The 25 test failures were known problems.
http://indiana-build.us.oracle.com/job/install_unit_tests_sparc/31/testReport/
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
