Hi Sue

Thanks for the review.

On 04/19/12 21:46, Sue Sohn wrote:
Nirmal,

The changes look ok.

I also happened to spot a couple more places that still have the
multiple parameters:
create_client.py: 194
set_service.py: 216
I'm fine if you fix these in a separate bug, since I know you have a
follow-on to 7154017 in the works.
I will fix them with the follow-on CR.

Thanks
Nirmal


Sue

On 04/19/12 08:34 AM, Nirmal Agarwal wrote:
Hi all

Can I please get a review for CR 7162589.

7162589 traceback creating default-i386 service after 7154017

webrev:

https://cr.opensolaris.org/action/browse/caiman/nirmal27/7162589/webrev/

Pep8 is clean and pylint output is unchanged.

I verified the scenario in the bug and the messages which I changed.

Thanks
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to