On 04/23/12 13:19, Jack Schwartz wrote:
Hi Ethan.
On 04/23/12 01:05 PM, Ethan Quach wrote:
Jack,
For this usage, we actually don't expect $PROFILE_DIR (or any files
in it really) to ever be a symlink. But in case a file inside the
dir is a symlink, the idea here is *not* to change the ownership of
the underlying file to 'aiuser'. i.e. 'aiuser' owns the symlink, can
remove it, copy in a real file to replace it, etc.
So I think -h is what I want here.
OK. Thanks for clarifying. I was actually surprised to see any link
handling at all. (If none is expected, why even have -h?)
Can you please clarify in the code that any unexpected links aren't to
be followed.
Sure, I'll update the comment to note that. Thanks for the review.
-ethan
Thanks,
Jack
thanks,
-ethan
On 04/23/12 11:27, Jack Schwartz wrote:
Hi Ethan.
Looks fine except for one thing:
auto-installer.src:
147: I think you want chown -R -H (cap H, not lower-case h). If
$PROFILE_DIR is a symlink, "-h" won't change the dir it points to
nor any files below it. "-H" will.
Thanks,
Jack
On 04/22/12 11:25 AM, Ethan Quach wrote:
Can I get a review of the following fixes.
BugIDs:
----------
7162980 <http://monaco.us.oracle.com/detail.jsf?cr=7162980> allow
aiuser to write to AI client's config profile directory
7111645 <http://monaco.us.oracle.com/detail.jsf?cr=7111645> useradd
next uid after install different in global zone and non global zone
7162573 <http://monaco.us.oracle.com/detail.jsf?cr=7162573> aiuser
user definition should not be a role.
Webrev:
----------
https://cr.opensolaris.org/action/browse/caiman/equach/aiuser/webrev/
Testing:
---------
On a freshly installed system, verified that 'aiuser' is no longer
a role.
On a freshly installed system, verified that 'aiuser' now has uid
61 and gid 61.
On a system updated to new package, verified that 'aiuser' has
updated uid and gid with no issues.
Built an AI image and created an install service from it.
Installed a client using this image and verified that a derived
manifest script can write to the config profile directory.
thanks,
-ethan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
