Hi Matt,

Thanks for the feedback.

On 24/04/2012 11:17, Matt Keenan wrote:
> Darren,
> 
> Mostly looks good.
> 
> software.dtd:
> 56:  "specified in is to be rejected"
>       should this be : "specified is to be rejected"

Fixed.

> 
> ips.py:
> 68: LICENSE_* definitions defined twice

Fixed.

> 
> test/test_info.py
> 368: tr_node.contents defined twice

(and in some other places too!)

Fixed.

> 
> ai_manifest.4:
> Lots of changes in here not related to what you are doing, not sure how 
> they made it into the diffs.

This is due to the fact that the man page is the latest from Alta,
containing changes from other projects too...

As mentioned in an e-mail earlier, I won't be delivering this anymore, and
it will be delivered later as part of the integration of the bugs:

  7163807 Need to sync up manpages in the slim_source gate
  7163809 ai_manifest.4 needs updating for RFE 7145997 - avoid/unavoid
          and reject changes.

(actually I think I missed the bug ids in the earlier mail - oops)

I've posted another webrev at:

  https://cr.opensolaris.org/action/browse/caiman/dkenny/7145997-1/webrev/

Thanks,

Darren.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to