Hi Sue Thanks for the review. Please find my reply inline. On 04/24/12 23:05, Sue Sohn wrote:
On 04/24/12 03:55 AM, Nirmal Agarwal wrote:Hi all,Can I please get a code review for CR 7159785. 7159785 some of ai-webserver message strings use multiple unnamed parameters webrev : https://cr.opensolaris.org/action/browse/caiman/nirmal27/7159785/webrev/ Source is Pep8 clean. Ran pylint and removed unused imports. I verified the messages which I changed by printing on python prompt. Thanks Nirmal _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discussHi Nirmal, With these changes, are all of the localization warning messages gone now from running nightly? Looks good, just a few nits create_profile.py 356 Your substitution looks fine, but can you modify: Error:\t writing profile -> Error writing profile
fixed.
data_files.py 381 add space after %
fixed.
delete_profile.py 132-135 Can you choose a different string besides 'file' since that is used for the deldict?
I have used "file" as we are accessing "file" key value in deldict. Let me know if you want it to be replaced with something else.
publish_manifest.py
479-486 Please reformat line to be less vertical, for example:
raise SystemExit(_
("Error:\tManifest has a range collision with manifest:"
"%(manifest0)s/%(manifest1)i\n\tin criteria: %(crit)s!") %
{'manifest0': man_inst[0], 'manifest1': man_inst[1],
'crit': crit.replace('MIN', '', 1).replace('MAX', '', 1)})
fixed. Please find the updated webrev(s). webrev : https://cr.opensolaris.org/action/browse/caiman/nirmal27/7159785-rev1/webrev/ Diff webrev (might not be of help because it shows other changes ) https://cr.opensolaris.org/action/browse/caiman/nirmal27/7159785-rev0-diff/webrev-rev0-diff/ Thanks Nirmal
Sue
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
