On 05/10/12 05:26, Nirmal Agarwal wrote:
Hi Shawn
Thanks for the review.
On 05/10/12 00:11, Shawn Walker wrote:
On 05/09/12 11:29, Jesse Butler wrote:
This looks good to me, but one question. Is svcprop always returning
lists delimited by backslashes now? If so, can you test
_get_nameservers() as well? I think it might need the same treatment.
I wrote some code to parse svcprop output a long time ago in pkg(5). I
won't claim its perfect, but it is well-tested:
http://src.opensolaris.org/source/xref/pkg/gate/src/modules/config.py#1637
Lines 1646-1679 should give you a nice dict structure of the output of
svcprop.
I went through the code and found that we are getting all the properties
of smf service. But this CR deals with particular property of smf. So as
of now, I would like to keep it as implemented.
Let me know what do you think ?
I wasn't expecting any changes; was merely pointing out some reference
code in case you had a case that you found was problematic.
-Shawn
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
