Harold: Thanks and LGTM. The deadline for integration of s11u1_17 is Monday 5/21 at 5:00 p.m. if you want to integrate into s11u1_17.
----- Original Message ----- From: [email protected] To: [email protected] Cc: [email protected] Sent: Friday, May 18, 2012 9:12:00 AM GMT -08:00 US/Canada Pacific Subject: Re: [caiman-discuss] Code Review - 7147174 followup Here is the updated webrev: Webrev: https://cr.opensolaris.org/action/browse/caiman/hshaw/7147174_pylint Harold On 05/18/12 09:49, Mary Ding wrote: > Harold: > > If you can post the webrev, that will be great. Thanks for making the change. > > > ----- Original Message ----- > From: [email protected] > To: [email protected] > Cc: [email protected] > Sent: Friday, May 18, 2012 7:47:19 AM GMT -08:00 US/Canada Pacific > Subject: Re: [caiman-discuss] Code Review - 7147174 followup > > I made the requested changes and reran the unit tests. Would you like > to see the webrev? > > Harold > > On 05/17/12 22:03, Mary Ding wrote: >> Harold: >> >> Can you take care of the following pylint unused import warnings: >> >> Reference is here: >> http://indiana-build.us.oracle.com/job/slim_code_cleanliness/Pylint_Audit/? >> >> >> from solaris_install.target.libefi.cstruct import EFI_MAXPAR >> DEFAULT_ZPOOL_NAME >> PARTITION_GUID_PTAG_MAP >> EFI_USR >> >> import sys >> >> Thanks !!! >> >> >> ----- Original Message ----- >> From: [email protected] >> To: [email protected] >> Sent: Thursday, May 17, 2012 4:17:53 PM GMT -08:00 US/Canada Pacific >> Subject: [caiman-discuss] Code Review - 7147174 followup >> >> I have made the requested changes to this fix. I have included both a >> full and differential webrev. Matt, if you wouldn't mind taking a >> look. I would appreciate it. >> >> CR: http://monaco.sfbay/detail.jsf?cr=7147174 >> >> Differential webrev: >> https://cr.opensolaris.org/action/browse/caiman/hshaw/7147174_diff >> Full webrev: >> https://cr.opensolaris.org/action/browse/caiman/hshaw/7147174_3 >> >> Testing: >> pep8 clean >> target selection unit tests have been run >> new unit tests added >> Full installs run on the default manifest and 2 representative manifests >> autoinstall -i -m run on a set of manifests developed to test the changes >> Note: Some have been added to the unit tests and some forwarded to QE >> to include in a new, more easily run AI test suite. >> >> Thanks, >> Harold >> _______________________________________________ >> caiman-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
