Mary,
Looks good to me.
John
On 05/21/12 02:48 PM, Mary Ding wrote:
Hi:
Can I get a code review for the following bug fix for .hgignore:
CR: http://monaco.sfbay/detail.jsf?cr=7169670 .hgignore issue with VIM
.swp files
Webrev is here:
https://cr.opensolaris.org/action/browse/caiman/md5645/7169670
Testing is done this way with suggestion from Darren Kenny:
I created some files under usr/src/cmd/installadm as follow:
indiana-build{mmding}150: cd installadm
/export/home/ding/7169670/slim_source/usr/src/cmd/installadm
indiana-build{mmding}151: ls
__init__.py client_control.py
image.py rename_service.py setup-sparc.sh
ai_smf_service.py create_client.py
installadm_common.py server.xml svc-install-server
ai-httpd-templ.conf create_service.py
installadm-common.sh service_config.py test/
aimdns_mod.py delete_client.py
installadm-convert.py service.py update_service.py
aimdns.py delete_service.py
installadm.py set_service.py
aimdnsd.py dhcp.py
list.py setup-image.sh
check-server-setup.sh grub.py
Makefile setup-service.sh
indiana-build{mmding}152: touch .test.swp .test.swa test.txt~ a~ b~
Without the fix, hg status will show them as follow:
indiana-build{mmding}153: hg status | grep swp
? usr/src/cmd/installadm/.test.swp
indiana-build{mmding}154: hg status | grep .test.swa
? usr/src/cmd/installadm/.test.swa
indiana-build{mmding}155: hg status | grep test.txt
? usr/src/cmd/installadm/test.txt~
indiana-build{mmding}156: hg status | grep a~
? usr/src/cmd/installadm/a~
indiana-build{mmding}157: hg status | grep b~
? usr/src/cmd/installadm/b~
indiana-build{mmding}158: pwd
/export/home/ding/7169670/slim_source/usr/src/cmd/installadm
With the fix in .hgignore, they will not show up at all as follow:
indiana-build{mmding}159: !153
hg status | grep swp
indiana-build{mmding}160: !154
hg status | grep .test.swa
indiana-build{mmding}161: !156
hg status | grep a~
indiana-build{mmding}162: !157
hg status | grep b~
indiana-build{mmding}163:
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
