Hi Matt,
The code changes look good to me.
There's one typo in lines 286 and 297: s/every/have/
Thanks,
--Karen
On 05/22/12 06:46, Matt Keenan wrote:
Hi,
Can I get two pairs of eyes to look over this fix please:
Bug
http://monaco.us.oracle.com/detail.jsf?cr=7165978
7165978 AI should create VARSHARE with compression as per /var
Webrev:
https://cr.opensolaris.org/action/browse/caiman/mattman/7165978
This bug was uncovered via zones testing. The default manifest for
zones installation specifies a BE option to turn on compression for
all datasets created within that zone. However as VARSHARE is not
within the BE it needs to inherit the compression property from var
dataset that's created within the BE.
The changes I've made allow for a user to still specify compression
for var and VARSHARE to be different via manually specification in an
AI manifest. A warning message is shown if they manually set it, but
installation will complete.
This CR also fixes a scenario for canmount not being set if VARSHARE
was specified in a manifest.
Testing:
- Build ISOS for AI, TI and GUI and tested full installs and verified
on first boot compression property set to the same value for var and
VARSHARE datasets.
- For AI and zones installs, I tried out a number of different
scenarios where compression is set with within BE or manually via
Filesystem elements for var and VARSHARE. Always ensuring that var
and VARSHARE are the same unless VARSHARE manually set.
- Ran full set of slim_source unit tests and no regressions found.
cheers
Matt
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
