Takeshi-san: Thank you for your review. I will update the RTI with your comments and review.
----- Original Message ----- From: [email protected] To: [email protected] Cc: [email protected] Sent: Wednesday, May 23, 2012 6:00:29 PM GMT -08:00 US/Canada Pacific Subject: Re: [caiman-discuss] code review request for 7170341 LGTM. Thanks, Mary. Takeshi On 2012年05月24日 03:00, Mary Ding wrote: > Takeshi-san: > > I had filed the following bug to track the problem with OCM and ASR: > > 7171004 - Need to have sizing of OCM and ASR labels together in order for > localization to work. > > I will work with Jack Schwartz to get this fixed. > > Meanwhile, I had update the webrev of 7170341 to reflect the fix with just > the 4 labels: > > https://cr.opensolaris.org/action/browse/caiman/md5645/7170341/ > > > > On 05/22/12 06:55 PM, Takeshi Asano wrote: >> Hi Mary, >> >> On 2012年05月23日 09:55, Mary Ding wrote: >>> Takeshi-san: >>> >>> I will file a seperate CR to address the sizing of area for label of the >>> two areas together. This is something that I am no familiar with and had no >>> idea how to fix it approriately. >>> >>> For the time being,is it OK to do _() for OCM and ASR as well, otherwise, I >>> will just remove _() if it is OK with you. >> >> Either is ok but if it's easy to remove _() from the two labels >> could you please do so, so no it's not needed to have tentative >> care by translators to keep width of the two labels manually. >> >> Thanks, >> Takeshi >>> On 05/22/12 05:48 PM, Takeshi Asano wrote: >>>> Hi Karen and Mary, >>>> >>>> Karen's point is valid and it's more appropriate >>>> internationalization to eliminate padding spaces from >>>> the static string and doing dynamic padding. >>>> >>>> But currently it seems that sizing of area for label >>>> " OCM Hub URL:" and that for "ASR Manager URL:" are >>>> being done separately. >>>> So the fix would need sizing of the two areas together. >>>> >>>> If the fix can be done within this CR, it'll be great. >>>> If not possible, addressing it in separate CR is also ok. >>>> >>>> Thanks, >>>> Takeshi >>>> >>>> On 2012年05月23日 08:56, Mary Ding wrote: >>>>> Karen: >>>>> >>>>> I will ask Takeshi-san about this and get back to you. >>>>> >>>>> On 05/22/12 04:51 PM, Karen Tung wrote: >>>>>> Hi Mary, >>>>>> >>>>>> I have a question for line 981. >>>>>> In the original strings, there are multiple empty spaces preceding "OCM >>>>>> Hub URL". >>>>>> I assume those are used for lining up with the string defined in >>>>>> ASR_HUB_LABEL. I see that those spaces >>>>>> are also included inside the _(). Do you know whether that's OK? I am >>>>>> wondering whether >>>>>> the spacing will get messed up if the spaces are included, and the >>>>>> translated >>>>>> string of "OCM Hub URL" is longer... >>>>>> >>>>>> Thanks, >>>>>> >>>>>> --Karen >>>>>> >>>>>> On 05/22/12 15:09, Mary Ding wrote: >>>>>>> Hi: >>>>>>> >>>>>>> Can I get a code review for the following bug fix for >>>>>>> usr/src/cmd/system-config/support.py >>>>>>> >>>>>>> CR: http://monaco.sfbay/detail.jsf?cr=7170341 several labels of >>>>>>> text-install/sysconfig support screens are not localizable >>>>>>> >>>>>>> >>>>>>> Web rev is here and is suggested by Takeshi-san: >>>>>>> >>>>>>> https://cr.opensolaris.org/action/browse/caiman/md5645/7170341 >>>>>>> >>>>>>> Testing is done this way: >>>>>>> >>>>>>> 1. Ran slim_install_unit tests for both sparc and x86. There were no >>>>>>> regression. >>>>>>> >>>>>>> x86 results pointer: >>>>>>> >>>>>>> /net/tcu27-01/export/home/ding/7170341/slim_source/usr/src/tools/tests/test_result >>>>>>> >>>>>>> sparc results pointer: >>>>>>> >>>>>>> /net/osol-bldsp/datapool/ding/7170341/slim_source/usr/src/tools/tests/test_result >>>>>>> >>>>>>> 2. Ran pep8 and pylint and there were no issues. >>>>>>> >>>>>>> 3. I use DC to build TI images for sparc and x86. >>>>>>> >>>>>>> x86 - TI installs works >>>>>>> sparc - TI installs works >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> caiman-discuss mailing list >>>>>>> [email protected] >>>>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>>>> >>>>> >>>>> _______________________________________________ >>>>> caiman-discuss mailing list >>>>> [email protected] >>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>> >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> [email protected] >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >> > _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
