Sue,
Looks good. My only comment is about the error string
at lines 203-205. Is it a new string that needs translation?
If so could the same error string that is used at lines 534-535
be used so as to not require additional translation?
534 raise ServiceCfgError(_('\nError: installation service properties'
535 ' do not exist for %s.\n') % (svcname))
Thanks,
John
On 05/29/12 09:37 AM, Sue Sohn wrote:
Can I get a couple of reviews of the changes for:
7150608 installadm create-service fails with KeyError: 'image_path'
http://monaco.us.oracle.com/detail.jsf?cr=7150608
Webrev:
https://cr.opensolaris.org/action/browse/caiman/sohn/7150608/webrev.7150608
Tests:
Performed the following tests before and after modifying the
configuration
file of a service to be similar to that in the bug report and
verified that
no tracebacks occurred.
Created a service that triggered the creation of the default-arch
alias
Enabled and disabled services
Deleted and recreated services.
Disabled and enabled the installadm SMF service
Ran unit tests (newly added tests pass and no new errors on existing
tests).
In addition, Bill ran the installadm test suites against the new
code and there
were no regressions.
Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
