Jack / Drew
Thanks for your review.
Thanks
Sreedhar
On Monday 23 July 2012 09:54 PM, Jack Schwartz wrote:
LGTM2.
Thanks,
Jack
On 07/23/12 06:23 AM, Drew Fisher wrote:
LGTM, Sreedhar!
Thanks!
-Drew
On 7/23/12 7:21 AM, Sreedhar Chalamalasetti wrote:
Thanks Drew.
Updated my webrev with suggested nit. Please find updated webrev
as follows.
https://cr.opensolaris.org/action/browse/caiman/sc157166/CR_7179890_7179900_1/webrev/
Thanks
Sreedhar
On 07/23/12 18:00, Drew Fisher wrote:
Sreedhar,
I know some of it isn't your code, but can we can all of the
try:
shutil.rmtree(somedir)
except:
pass
to:
shutil.rmtree(somedir, ignore_errors=True)
?
Otherwise, this LGTM.
-Drew
On 7/23/12 4:04 AM, Sreedhar Chalamalasetti wrote:
Hi
Could you please review the following test suite fixes
7179890 lib/install_ict/test leaves /tmp/ict_test* behind and
forget to clean up.
7179900 lib/install_transfer leaves /tmp/logging* behind after
running tests.
Webrev:
https://cr.opensolaris.org/action/browse/caiman/sc157166/CR_7179890_7179900/webrev/
Bug: The /tmp/ict_test* and /tmp/logging* directories not removed
as part of tearDown function in install_ict and install_tranfer
test cases.
Solution: Remove these directories as part of tearDown function.
Tests Performed:
-Executed "./slim_test lib/install_ict/test", Verified that
no stale directories "ict_test*" under /tmp directory.
-Executed "./slim_test lib/install_transfer/test", Verified
that no stale directories "logging_*" under /tmp directory.
-pep8 - clean
-Nightly completed successfully.
Thanks
Sreedhar
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
