Nirmal:
Changes is OK for executable permissions.
As for copyright, it will be better to follow the ON rules on copyright.
On 07/23/12 11:32 AM, Jack Schwartz wrote:
Hi Nirmal.
Changes seem OK, but...
Is this part of an ongoing task to remove X permissions from new
pushes of test files to the gate? I ask because there are other older
tests in the gate which have X permissions set. I guess it makes
sense to deliver files with as few permissions as necessary from a
security point of view, but here I'm not sure it makes much difference...
Also, from ON's rules on copyrights, it doesn't look like you need to
modify the copyright if you are changing only the permissions. See the
section on "Significant modification" here:
http://on11update-gate.us.oracle.com/copyright-policy.html
To be sure, consult with a gatekeeper.
Thanks,
Jack
On 07/23/12 11:15 AM, Nirmal Agarwal wrote:
Hi Jack , Mary
Apart from the changes in the earlier webrev, I am removing the
executable permission on all files in directory
usr/src/lib/install_manifest/test/.
webrev location :
http://jurassic.us.oracle.com/net/10.134.125.27/export/home/nirmal/7179899/webrev/
changes from previous webrev :
-- year change
-- removed executable permission
Thanks
Nirmal
On 7/19/2012 11:58 PM, Mary Ding wrote:
Nirmal:
LGTM and thanks for fixing the tests.
On 07/19/12 05:50 AM, Nirmal Agarwal wrote:
Thanks Jack for the review.
I would need 1 more reviewer for this.
Thanks,
Nirmal
On 07/19/12 00:29, Jack Schwartz wrote:
Thanks, Nirmal. LGTM.
Jack
On 07/18/12 11:23 AM, Nirmal Agarwal wrote:
Hi Jack,
Thanks for the review. I have modified the fix as per your comments.
Please find the webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7179899/webrev/
I re-ran the tests to confirm that manifest file gets deleted.
Thanks,
Nirmal
On 7/18/2012 10:46 PM, Jack Schwartz wrote:
Hi Nirmal.
Here are my comments:
test_mw_dry_run.py:
61: I suggest using os.path.exists() instead of os.path.isfile().
I suggest testing for mw_cp._manifest and removing it if it exists,
inside a finally clause hanging off the try of line 97. That way if
an exception occurs, mw_cp._manifest will still be deleted.
test_mw_with_engine.py:
57: os.path.exists() instead of os.path.isfile()
test_mw_without_engine.py:
59: os.path.exists() instead of os.path.isfile()
Thanks,
Jack
On 07/18/12 06:01 AM, Nirmal Agarwal wrote:
Hi all,
Can I please get review for CR 7179899.
7179899 lib/install_manifest/test leaves
/tmp/test_manifest_writer_01_z1YC7Y.xml behind after running tests
webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7179899/webrev/
Testing :
Verified that /tmp/test_manifest_writer_01* doesn't exist after
running the tests.
Pep8 is clean.
Pylint : removed some of unused imports.
Thanks,
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
