Everything look good to me now.
Thanks,
--Karen
On 07/27/12 04:53 PM, Swati Sarraf wrote:
Hi Karen
Thanks for the review. I have corrected the nits you mentioned.
Webrev : https://cr.opensolaris.org/action/browse/caiman/ssarraf/7187287/
-Thanks
Swati Sarraf
----- Original Message -----
From: [email protected]
To: [email protected]
Cc: [email protected]
Sent: Friday, July 27, 2012 4:21:56 PM GMT -08:00 US/Canada Pacific
Subject: Re: [caiman-discuss] CR: 7187287 ( might be a stopper bug)
Hi Swati,
A few nits:
- line 42: I think this line should be move to line 39, above the
"import osol_install..." line,
because "math" is a system module, and the import of functions from it
should go before
the vendor-package modules.
- line 717 and 721: I think the indentation of these 2 lines are too
much, they should only
have 4 characters indentation.
Thanks,
--Karen
On 07/27/12 03:53 PM, Swati Sarraf wrote:
Hi All,
Can I have a quick code review for this bug fix. It might be a stopper bug.
7187287: Bug 7163694 fixes in gui-install/disk_screen.py are removed due to
mismerge b/w bug 7163694&7183018
http://monaco.us.oracle.com/detail.jsf?cr=7187287
Webrev link:
https://cr.opensolaris.org/action/browse/caiman/ssarraf/7187287/
Testing is done as follow:
1. slim test done,result OK
test-pointer:
file:///net/osol-bldx/datapool/ssarraf/7187287/slim_source/slimtest-27july
2. pep8 and pylint test done, result OK
3. Created DC image for gui-livecd to checked the size display screen for
minimum and recommended size and also, completed the installation with minimum
size.
-Thanks
Swati Sarraf
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
