Hi Nirmal.
Changes look fine.
BTW, I noticed the file set to 0755 permissions. I thought the
convention was to set 0644 and have the perms changed if needed when
files are installed to the proto area. That said, files were like that
before your fix, and fixing that would balloon this task at a time when
changes should be kept simple.
Thanks,
Jack
On 08/ 2/12 01:46 AM, Nirmal Agarwal wrote:
Hi all,
Can I please get 2 code reviewers for CR 7188319.
7188319 js2ai Traceback error : NameError: global name '_' is not defined
webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7188319/webrev/
Slim test : ran js2ai slim test and all tests pass.
Pep8 : clean
Pylint : fixed muliple import of os module.
Testing :
Tested the scenario mentioned in the CR and I was able to convert the
profile.
Regards,
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
