Hi Karen and everyone.
Changes LGTM.
For the record, we discussed adding a comment to the manifests
cautioning about putting linefeeds and spaces in kwargs. This would
enlighten people who would change the manifest, and prevent this kind of
thing in the future. However, we concluded that if we added such a
comment here, we should add it to all manifests, which would balloon
testing efforts and the idea right now is to keep things simple.
Thanks,
Jack
On 08/ 2/12 04:29 PM, Karen Tung wrote:
Hi,
Please review my changes to fix:
7188249 sort file for solaris.zlib is not used by DC at all
http://monaco.us.oracle.com/detail.jsf?cr=7188249
webrev:
https://cr.opensolaris.org/action/browse/caiman/ktung/7188249/webrev/
There are 4 files in the webrev. Only the 2 DC manifests are worth
reviewing.
The 2 sort files are generated. Even though there are a lot of changes
in them, there is no need to really review them.
Testing:
- Built Live CD and x86 Text Installer images using the newly
generated files.
Made sure they boot correctly, and the boot time is improved.
I also did installs using both images to make sure they work.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
