LGTM too.
Thanks John for tracking this down...
Darren.
On 22/08/2012 18:44, John Fischer wrote:
> Dermot,
>
> Great question. I should have stated that I choose Finished instead of
> Install Completed
> because Finished is already translated.
>
> finish_screen.py: self.set_titles(_("Finished"), _(" "), None)
>
> Thanks,
>
> John
>
>
> On 08/22/12 10:41 AM, Dermot McCluskey wrote:
>> Hi John,
>>
>> The fix looks good.
>>
>> Just checking: is it OK to introduce new l10n messages at this point?
>>
>> - Dermot
>>
>>
>>
>> On 08/22/12 18:16, John Fischer wrote:
>>> All,
>>>
>>> Can I get a code review for CR 7190194:
>>>
>>> http://monaco.us.oracle.com/detail.jsf?cr=7190194
>>> 7190194 [A11Y]GUI installer hung on last screen w/accessibility
>>> installation and networking disabled
>>>
>>> The webrev is located at:
>>>
>>>
>>> https://cr.opensolaris.org/action/browse/caiman/johnfisc/7190194_GUI_hang/
>>>
>>> The fix is simply to get the GUI to update within the correct thread
>>> for the process.
>>> I also believe that it only happens on slower processors. Since no
>>> one within the
>>> group could reproduce it I have produced an ISO image and requested
>>> the submitter
>>> to test the fix. He has stated that the new fix works fine. The ISO
>>> is listed in the
>>> CR for those who want to test it.
>>>
>>> I believe that this is a stopper bug as the install hangs even though
>>> it has completed.
>>> I have asked Dave Miner for integration approval. Once he grants it
>>> I will flip the stopper
>>> status.
>>>
>>> Thanks,
>>>
>>> John
>>> _______________________________________________
>>> caiman-discuss mailing list
>>> [email protected]
>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
> _______________________________________________
> caiman-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
