Hi Nirmal,
please see my comments below.
Jan
55-57 - I didn't notice that previously, but this text desires some
modifications
to remain in sync with changed validation algorithm. I am not sure
though if/how
it could be touched at this point (I recommend to check with Dave, Drew).
224 - It seems that validation() method now serves two purposes:
[a] it validates each key press when user is in process of typing hostname
[b] it takes care of final validation of all parameters when user leaves
the screen
If my understanding is correct, could you please clarify that in comment
section
on lines 225-226 to make life of future maintainers of that code easier ?
257-264 I am wondering if this common code path can ever be exercised
in [b] scenario (when user is leaving the screen). If not, then I may
recommend
to move that into block dealing with [a] (lines 230-234) to make that clear.
On 08/23/12 02:12 PM, Nirmal Agarwal wrote:
Hi all,
Can I please get CR 7191720 re-reviewed after changes suggested by rti
advocate.
Webrev:
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7191720-rev3/webrev/
Webrev-diff:
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7191720-diff/webrev.diff/
Testing :
I re-tested the following cases :
--> hostname can contain "."
--> hostname should not start or end with "." or "-"
--> hostname should contain atleast 1 alphabet or '.' or '-'.
Thanks,
Nirmal
On 08/22/12 00:43, swati.sarraf wrote:
Hi Nirmal,
Looks good to me.
-Thanks
Swati
On 08/21/12 11:41 AM, Nirmal Agarwal wrote:
Mary,
I will file RFE for this.
Thanks,
Nirmal
On 8/21/2012 11:46 PM, Mary Ding wrote:
Nirmal:
Is there unit tests to cover this ??? It will be good to enhance
the install unit tests to cover this or file an rfe to get QE to
enhance the sysconfig test suite to cover these scenarios. Can you
file an rfe to cover this ??
Thanks !!!
On 08/21/12 12:24 AM, Nirmal Agarwal wrote:
Hi all,
Can I please get 2 code reviewers for CR 7191720.
7191720 <http://monaco.us.oracle.com/detail.jsf?cr=7191720> S11
sysconfig doesn't allow . in the hostname
webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7191720/webrev/
Pep8 is clean.
Pylint output is unchanged.
Testing :
I have tested the code with the following inputs.
--> hostname can contain "."
--> hostname should not start or end with "." or "-"
--> hostname should contain atleast 1 alphabet or '.' or '-'.
Thanks,
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
