Review: Approve Hello
Thank you for this new applet! :) I just quickly tested it and it seems working fine! I just have a few ideas/suggestions: * If the download directory doesn't exist (by default ~/Videos), there is a problem but it's not explained what's the problem. * I also suggest to use the translated name for the default folder (check this file ~/.config/user-dirs.dirs or use the output of this command: xdg-user-dir VIDEOS ) * By default, it's maybe better to use Cairo-Dock's dialogues instead of pynotify (or at least having an option to use these dialogues) * Why do you use a list in the dialogue when we do a left click? * For the 'Applet Help' dialogue, you can use a 'ShowDialog' with a timeout of 0 (and no button) * About this dialogue, there is another entry in YoutubeDL / Applet's Handbook: what's the difference? PS: now you can use this command to sync with the master branch: bzr pull lp:cairo-dock-plug-ins-extras -- https://code.launchpad.net/~mycompostpile/cairo-dock-plug-ins-extras/YoutubeDl/+merge/108080 Your team Cairo-Dock Team is subscribed to branch lp:cairo-dock-plug-ins-extras. _______________________________________________ Mailing list: https://launchpad.net/~cairo-dock-team Post to : [email protected] Unsubscribe : https://launchpad.net/~cairo-dock-team More help : https://help.launchpad.net/ListHelp
