Review: Needs Fixing Hello Eduardo and thank you for these modifications ;)
It looks fine (even if I'm not able to test it right now ;) ). We are still using 'last-modif' file but this file is managed by the dock, no need to modify it ;) (it's used to know if the dock has to update this applet or not). But is it possible to modify the 'last-modif' entry of your Twitter applet in 'list.conf' file too? We regularly forgot it :) Format is YYYYMMDD (this number has to be bigger each day) Then, you can push your modifications on the main branch ;) (or I can do that if you prefer) Also: here is just a 2 tips/advices (mostly details): * About the commit message, it's maybe better to start it with the name of the applet (just "Twitter: Updating (...)") => For more advices about the commit message, please have a look there: http://www.glx-dock.org/ww_page.php?p=Help%20us%20with%20BZR&lang=en#18-About%20the%20commit%20message * No need to bump the version number of your applet if you don't change the .conf file (but you can do that if you want to have a detailed changelog for each modification but you can also have a version number and a lot of changes and in your ChangeLog file, you can add the date ;) ) Have a nice day, Matt -- https://code.launchpad.net/~eduardo-mucelli/cairo-dock-plug-ins-extras/Twitter/+merge/179046 Your team Cairo-Dock Third-Party is subscribed to branch lp:cairo-dock-plug-ins-extras. _______________________________________________ Mailing list: https://launchpad.net/~cairo-dock-team Post to : [email protected] Unsubscribe : https://launchpad.net/~cairo-dock-team More help : https://help.launchpad.net/ListHelp
