Also, if we are adding functionality to a plug-in, or fixing something that doesn't quite work. We should probably committing that code back with the owner of the plug-in. Considering most plug-in developers are scratching their own itch, and not necessarily doing a market needs assessment to determine how they could make the plug-in more robust, it would be a nice way for us to 'pay' for the use of the code that does fit our needs by committing additional things back to the original. This would also mitigate the need to try and manually incorporate changes from the main line of code when they do release thing.
Vinnie On Friday, June 22, 2012 6:39:50 AM UTC-4, Ratty wrote: > > On 22/06/12 04:03, Jamie wrote: > > > > On Thursday, June 21, 2012 9:23:44 AM UTC-7, Ratty wrote: >> >> You should not be changing any plugin code anyway. That's why they are >> plugins... >> You update them straight from github when you need to. If you want to >> modify >> the behaviour of a plugin model for example then you can extend it in >> your own >> model and override the functions you need to change. You should not be >> copying >> the plugin into your application and modifying it which is, I think, >> what you are suggesting ? >> > > I think that's poor advice. If I download a third party plugin that's > not part of the Cake core, of course I'm going to modify it to suit my > needs. There's absolutely nothing wrong with that. If you need to change a > plugin, then change it. The only code that most people shouldn't be messing > with is the core, though if you know what you're doing and you're careful, > that's not a sin either. > > Remember, at the end of the day, the code works for you - not the other > way around. > > - Jamie > -- > Our newest site for the community: CakePHP Video Tutorials > http://tv.cakephp.org > Check out the new CakePHP Questions site http://ask.cakephp.org and help > others with their CakePHP related questions. > > Well as long as you are happy to change it again and again every > time they fix bugs and re-release the plugin then that's fine. > > > Personally, I would rather install it and have it working in a couple of > minutes rather than remembering how I modified it last time. > > Steve. > -- Our newest site for the community: CakePHP Video Tutorials http://tv.cakephp.org Check out the new CakePHP Questions site http://ask.cakephp.org and help others with their CakePHP related questions. To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/cake-php
