for starters, take out the validation redundancy
why setting the errors to the view? also not necessary
also, in 2.x your __() looks differently (arguments usually are not "true"
but replacement strings)
why dont you use baking? it would display a better output than you
currently have
Am Freitag, 3. August 2012 17:43:52 UTC+2 schrieb MetZ:
>
> Yes, I understand what you are doing :)
> Have a couple of those myself..
>
> But my question is (perhaps not clear enough), the best practice for a
> function like add and edit.
>
> I am thinking about:
> if ($this->request->is('post')) {
> $this->User->set($this->request->data);
> if ($this->User->validates()) {
> ++++
>
> Those things inside the function. Like,, what approach/setup would you use
> on cake 2.x to talk with the db and make things happen :)
>
> I am just wondering if I am doing it 100% correct, as I can not find any
> good tutorials on it anywhere..
>
> Here is my add function as is today, any pointers?
>
> public function admin_add() {
> $this->set('title_for_layout', __('Add new role',true));
> if ($this->request->is('post')) {
> $this->Role->set($this->request->data);
> if ($this->Role->validates()) {
> if ($this->Role->save($this->request->data)) {
> $this->Session->setFlash(__('New role created.',true),
> 'admin/flash/success');
> $this->redirect(array('action' => 'index'));
> } else {
> $this->Session->setFlash(__('Could not create role, please try
> again.',true), 'admin/flash/error');
> }
> } else {
> // Didn't validate
> }
> }
> $this->set('errors', $this->Role->validationErrors);
> }
>
> -Tom
>
>
>
> kl. 13:35:30 UTC+2 fredag 3. august 2012 skrev SoulRaven følgende:
>>
>> i use a single method, add/edit even if is user or admin,
>> the difference between add/edit is that on edit you have the ID set, or in
>> parameter or in $this->data
>>
>> admin_editpost($id = null){
>> if(is_null($id){
>> //something
>> }
>> }
>>
>> i guess you understand
>>
>> vineri, 3 august 2012, 11:41:01 UTC+3, MetZ a scris:
>>>
>>> Hi all..
>>>
>>> I am in the process of migrate one of my apps fra 1.3 to cakephp 2.x
>>> and I am wondering, what are the best practices for the new framework?
>>> AND YES, I have read the documents/book :)
>>>
>>> I am just wondering how you do it, so I can compare my work and see if I
>>> am heading in the right direction with my app.
>>>
>>> So if anyone could give me an idea about a couple simple add/edit
>>> functions, and how the best practice for this, I would appreciate it :)
>>>
>>> like:
>>>
>>> admin_users_add() {
>>> }
>>>
>>> admin_users_edit() {
>>> }
>>>
>>> and other regular functions you might have an example for.
>>>
>>> Thanks all!
>>> Awesome!
>>>
>>> -Tom
>>>
>>
--
Our newest site for the community: CakePHP Video Tutorials
http://tv.cakephp.org
Check out the new CakePHP Questions site http://ask.cakephp.org and help others
with their CakePHP related questions.
To unsubscribe from this group, send email to
[email protected] For more options, visit this group at
http://groups.google.com/group/cake-php
