Pete Heist <[email protected]> writes: >> On Feb 8, 2017, at 5:11 PM, Toke Høiland-Jørgensen <[email protected]> wrote: >>> >>> That reminds me, is there any way to disable fq-codel in the ath9k >>> driver, and revert to being able to use the qdisc layer without >>> limiting? Then I could do this testing without having to install Chaos >>> Calmer, and it could avoid some re-flashing in case I need to re-test >>> something in the new driver code again. >> >> Nope, no way to turn it off. > > Ok, it would be convenient for testing.
Yeah, but "it should be easy to test how crappy the old code was" is not a very good argument for putting code into the kernel ;) What you can do is have two different versions of mac80211.ko and ath9k.ko and reload them between your test runs. There's even code in Flent to capture the module version which you can use to distinguish between the cases. > Also, could the queue management code be abstracted into a separate > module, so it can be replaced, like a qdisc? I don’t know if the > disparity between hardware makes this too difficult or not… Well it's abstracted into mac80211 so all wireless drivers can use it (theoretically; right now only ath9k, ath10k and the not-yet-merged mt76 do). Making it more generic than that is not possible, since it's tied to the mac80211 data structures. Which is kinda the point; the whole problem was that a "generic layer" (the qdisc) didn't work well enough... -Toke _______________________________________________ Cake mailing list [email protected] https://lists.bufferbloat.net/listinfo/cake
