On Tue, Nov 21, 2017 at 04:58:54PM -0800, Dave Taht wrote: > Stephen Hemminger <[email protected]> writes: ... > > Also, when I see multiple arrays of same size. It seems the API should > > be: > > struct tc_cake_tin_stats { > > __u32 threshold_rate; > > __u32 target_us; > > struct tc_cake_traffic_stats sent; > > ... > > > > What if you want to change number of TINS, the ABI shouldn't have to change. > > It is hard to imagine ever wanting more than 8 tins. Using up 3, sanely, > has proven hard.
Which means each stats dump will almost always dump 5 empty TINS, while if it were dynamic, it could dump only the 1, 2 or 3 in use and probably help with the stats dump performance. Smaller slab, less bytes to copy, ... Marcelo _______________________________________________ Cake mailing list [email protected] https://lists.bufferbloat.net/listinfo/cake
