On Wed, Apr 25, 2018 at 6:32 PM, Stephen Hemminger <[email protected]> wrote: > On Thu, 26 Apr 2018 10:40:29 +0930 > Ryan Mounce <[email protected]> wrote: > >> I'll investigate making the ACK filtering code safe, it is my mess after all >> :) >> >> Eric obviously understands this stuff a lot better than me, it looks >> like there are two issues? >> - Lack of minimum length check for TCP header, should be fairly >> straight-forward to fix >> - The possibility of unsafely filtering part of a split GSO super-packet? >> >> Regards, >> Ryan Mounce >> >> [email protected] >> 0415 799 929 > > > It makes more sense to move it out of Cake altogether. Cake is already one > of those projects that seems to have Golden Hammer disease. > https://en.wikipedia.org/wiki/Law_of_the_instrument > > Why not in netfilter or XDP? Then it could be used in other contexts like > tunnels or selectively based on route etc.
'cause it needs a queue and state. netfilter doesn't have a queue. _______________________________________________ > Cake mailing list > [email protected] > https://lists.bufferbloat.net/listinfo/cake -- Dave Täht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619 _______________________________________________ Cake mailing list [email protected] https://lists.bufferbloat.net/listinfo/cake
