> On 6 Jul, 2018, at 4:21 pm, Toke Høiland-Jørgensen <[email protected]> wrote: > >> I'm handling it without using any extra permanent state, just making >> use of what's already there. Take a look at latest commit. > > Yup, that also fixes the infinite loop issue. I'm fine with doing it > this way; however, it doesn't handle the other places where we check > whether sch->q.qlen is nonzero. Are you sure that is not going to give > us more problems down the road? :)
The other places are checking whether the queue is empty for the purposes of updating the shaper state. They are therefore much less critical, and I think self-correcting. - Jonathan Morton _______________________________________________ Cake mailing list [email protected] https://lists.bufferbloat.net/listinfo/cake
