On 7/19/18 9:20 AM, Toke Høiland-Jørgensen wrote: > David Ahern <[email protected]> writes: > >> On 7/19/18 4:53 AM, Toke Høiland-Jørgensen wrote: >>> A few comments below; will fix the rest. >>> >>>>> + print_uint(PRINT_JSON, "bandwidth", NULL, bandwidth); >>>>> + print_string(PRINT_FP, NULL, "bandwidth %s ", >>>>> sprint_rate(bandwidth, b1)); >>>>> + } else >>>>> + print_string(PRINT_ANY, "bandwidth", "bandwidth %s ", >>>>> "unlimited"); >>>>> + } >>>>> + if (tb[TCA_CAKE_AUTORATE] && >>>>> + RTA_PAYLOAD(tb[TCA_CAKE_AUTORATE]) >= sizeof(__u32)) { >>>>> + autorate = rta_getattr_u32(tb[TCA_CAKE_AUTORATE]); >>>>> + if(autorate == 1) >>>>> + print_string(PRINT_ANY, "autorate", "autorate_%s ", >>>>> "ingress"); >> >> This just caught me eye as well ... why the '_' after autorate? > > Well, the parameter is called autorate_ingress to make it a single > token. When adding JSON support I picked the key/value representation > mostly because we could theoretically add other autorate modes in the > future (the netlink parameter allows it).
ok, just seems odd that json and stdout representations are different. _______________________________________________ Cake mailing list [email protected] https://lists.bufferbloat.net/listinfo/cake
