I hope this shows up as an inbound shaping improvement for us. skb_clone was *expensive*
---------- Forwarded message --------- From: David Miller <[email protected]> Date: Mon, Jul 30, 2018 at 9:32 AM Subject: Re: [PATCH net-next v5 0/4] TC: refactor act_mirred packets re-injection To: <[email protected]> Cc: <[email protected]>, <[email protected]>, <[email protected]>, <[email protected]>, <[email protected]>, <[email protected]>, <[email protected]> From: Paolo Abeni <[email protected]> Date: Mon, 30 Jul 2018 14:30:41 +0200 > This series is aimed at improving the act_mirred redirect performances. > Such action is used by OVS to represent TC S/W flows, and it's current largest > bottle-neck is the need for a skb_clone() for each packet. > > The first 2 patches introduce some cleanup and safeguards to allow extending > tca_result - we will use it to store RCU protected redirect information - and > introduce a clear separation between user-space accessible tcfa_action > values and internal values accessible only by the kernel. > Then a new tcfa_action value is introduced: TC_ACT_REINJECT, similar to > TC_ACT_REDIRECT, but preserving the mirred semantic. Such value is not > accessible from user-space. > The last patch exploits the newly introduced infrastructure in the act_mirred > action, to avoid a skb_clone, when possible. > > Overall this the above gives a ~10% performance improvement in forwarding > tput, > when using the TC S/W datapath. ... Series applied, thank you. -- Dave Täht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619 _______________________________________________ Cake mailing list [email protected] https://lists.bufferbloat.net/listinfo/cake
