> On Aug 29, 2018, at 3:04 AM, Dave Taht <[email protected]> wrote:
>
> Anyway, this should be a drop in replacement (presently) for fq_codel,
> that compiles out of tree and rips out almost everything I don't like.
>
> https://github.com/dtaht/fq_codel_fast
Cool…I’d give it a quick run but it doesn’t compile for me (attached). Kernel
version?
> I think the tc filter thing really hurt us in cake.
It would be interesting to see how much. Jon also expressed concern and I’d
been meaning to try some benchmarks before and after that change…
root@ubuntu:~/src/fq_codel_fast$ make
make -C /lib/modules/4.15.0-33-generic/build SUBDIRS=/root/src/fq_codel_fast
modules LDFLAGS_MODULE="--build-id=0xa524fc2e39dc291199b9b04fb890ea1548f17641"
CFLAGS_MODULE="-DCAKE_VERSION=\\\"a524fc2e39dc291199b9b04fb890ea1548f17641\\\""
make[1]: Entering directory '/usr/src/linux-headers-4.15.0-33-generic'
CC [M] /root/src/fq_codel_fast/sch_fq_codel.o
/root/src/fq_codel_fast/sch_fq_codel.c: In function âfq_codel_initâ:
/root/src/fq_codel_fast/sch_fq_codel.c:444:8: error: too many arguments to
function âtcf_block_getâ
err = tcf_block_get(&q->block, &q->filter_list, sch, extack);
^~~~~~~~~~~~~
In file included from /root/src/fq_codel_fast/sch_fq_codel.c:26:0:
./include/net/pkt_cls.h:41:5: note: declared here
int tcf_block_get(struct tcf_block **p_block,
^~~~~~~~~~~~~
/root/src/fq_codel_fast/sch_fq_codel.c:449:14: error: implicit declaration of
function âkvcallocâ; did you mean âkvzallocâ?
[-Werror=implicit-function-declaration]
q->flows = kvcalloc(FQ_FLOWS,
^~~~~~~~
kvzalloc
/root/src/fq_codel_fast/sch_fq_codel.c:449:12: warning: assignment makes
pointer from integer without a cast [-Wint-conversion]
q->flows = kvcalloc(FQ_FLOWS,
^
/root/src/fq_codel_fast/sch_fq_codel.c:456:15: warning: assignment makes
pointer from integer without a cast [-Wint-conversion]
q->backlogs = kvcalloc(FQ_FLOWS, sizeof(u32), GFP_KERNEL);
^
/root/src/fq_codel_fast/sch_fq_codel.c: At top level:
/root/src/fq_codel_fast/sch_fq_codel.c:652:15: error: initialization from
incompatible pointer type [-Werror=incompatible-pointer-types]
.tcf_block = fq_codel_tcf_block,
^~~~~~~~~~~~~~~~~~
/root/src/fq_codel_fast/sch_fq_codel.c:652:15: note: (near initialization for
âfq_codel_class_ops.tcf_blockâ)
/root/src/fq_codel_fast/sch_fq_codel.c:667:11: error: initialization from
incompatible pointer type [-Werror=incompatible-pointer-types]
.init = fq_codel_init,
^~~~~~~~~~~~~
/root/src/fq_codel_fast/sch_fq_codel.c:667:11: note: (near initialization for
âfq_codel_qdisc_ops.initâ)
/root/src/fq_codel_fast/sch_fq_codel.c:670:13: error: initialization from
incompatible pointer type [-Werror=incompatible-pointer-types]
.change = fq_codel_change,
^~~~~~~~~~~~~~~
/root/src/fq_codel_fast/sch_fq_codel.c:670:13: note: (near initialization for
âfq_codel_qdisc_ops.changeâ)
cc1: some warnings being treated as errors
scripts/Makefile.build:339: recipe for target
'/root/src/fq_codel_fast/sch_fq_codel.o' failed
make[2]: *** [/root/src/fq_codel_fast/sch_fq_codel.o] Error 1
Makefile:1552: recipe for target '_module_/root/src/fq_codel_fast' failed
make[1]: *** [_module_/root/src/fq_codel_fast] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-4.15.0-33-generic'
Makefile:8: recipe for target 'default' failed
make: *** [default] Error 2
_______________________________________________
Cake mailing list
[email protected]
https://lists.bufferbloat.net/listinfo/cake
