Eric Dumazet <[email protected]> writes: > On 01/07/2019 11:47 AM, Toke Høiland-Jørgensen wrote: >> From: Toke Høiland-Jørgensen <[email protected]> >> >> With GSO splitting in sch_cake, we can decrease as well as increase the >> qlen. To make it possible to signal this up the qdisc tree, change >> qdisc_tree_reduce_backlog() to accept signed integer values as the number >> of packets and bytes to reduce the backlog by. > > > Not sure why this patch is needed, given we use u32 integers > for q.qlen & qstats.backlog > > 0xFFFFFFFF for n is really -1 once folded... > > sch->q.qlen -= n; > sch->qstats.backlog -= len;
Sure, it works without the patch, but changing to int properly communicates the intent (that negative values are allowed) rather than rely on overflow behaviour... -Toke _______________________________________________ Cake mailing list [email protected] https://lists.bufferbloat.net/listinfo/cake
