Kevin Darbyshire-Bryant <[email protected]> writes: >> On 3 May 2019, at 15:22, Toke Høiland-Jørgensen <[email protected]> wrote: >> >> Kevin Darbyshire-Bryant <[email protected]> writes: >> >>> Hi Everyone, >>> >>> I’ve been working on act_ctinfo toward getting that upstream and it is >>> getting closer. Since that module along with act_connmark does its own >>> conntrack lookups I’ve been looking at what they do and what we do in >>> cake. >>> >>> Two patches attached - one is a simple variable elimination with no >>> functional change. The second changes/simplifies the conntrack tuple >>> lookup & usage. I’ve had a play and I don’t think I’ve broken any of >>> the host fairness BUT it could do with some more testing, that’s where >>> you come in… probably Pete & George :-) >> >> Seems reasonable. But please fold these two patches into one; changing >> everything, then immediately changing it again does not help >> readability... And the explanation makes a lot more sense if you just >> change the whole thing in one patch :) >> >> -Toke > > Yeah, when I do the PR after testing confirms I haven’t totally > screwed up host fairness in the process I’ll of course squash them > together :-)
Cool :) -Toke _______________________________________________ Cake mailing list [email protected] https://lists.bufferbloat.net/listinfo/cake
