> On 18 Feb, 2024, at 2:01 am, Dave Taht via Cake <cake@lists.bufferbloat.net> > wrote: > > Does anyone remember why we do not ack-filter a gso-split?
That may actually be unintentional. The original code self-recursed, IIRC, so individual segments would then go through the non-gso-split path. At some point we inlined it for efficiency. The thing to try might be to copy the relevant code (both the search and the drop) into the gso-split path and see if anything breaks, and if the ack-dropping statistics tend to increase. - Jonathan Morton _______________________________________________ Cake mailing list Cake@lists.bufferbloat.net https://lists.bufferbloat.net/listinfo/cake
