The collectionURL() method should return a URL ending in '/'. The caller shouldn't have to append it.

If the caller does do it (for extra-sure-ness) it should make sure their isn't a trailing '/' already. This should be a general rule when getting a collection URL if you aren't sure it has a trailing '/'. Better yet would be an assertion, since there is no reason why collectionURL() should ever be returning a URL without the trailing '/'.

        -wsv


On Nov 22, 2006, at 9:55 PM, [EMAIL PROTECTED] wrote:

Revision
578
Author
[EMAIL PROTECTED]
Date
2006-11-22 19:55:52 -0800 (Wed, 22 Nov 2006)
Log Message

Collection URL must end in "/".
Modified Paths

CalendarServer/branches/users/wsanchez/provisioning-2/twistedcaldav/ directory/resource.py
Diff

Modified: CalendarServer/branches/users/wsanchez/provisioning-2/ twistedcaldav/directory/resource.py (577 => 578)

--- CalendarServer/branches/users/wsanchez/provisioning-2/ twistedcaldav/directory/resource.py 2006-11-23 00:18:55 UTC (rev 577) +++ CalendarServer/branches/users/wsanchez/provisioning-2/ twistedcaldav/directory/resource.py 2006-11-23 03:55:52 UTC (rev 578)
@@ -126,7 +126,7 @@
@param directory: an L{IDirectoryService} to provision calendars from.
         @param recordType: the directory record type to provision.
         """
- CalendarPrincipalCollectionResource.__init__(self, joinURL (parent.collectionURL(), recordType)) + CalendarPrincipalCollectionResource.__init__(self, joinURL (parent.collectionURL(), recordType) + "/")
         DAVFile.__init__(self, path)

         self.directory = parent.directory
_______________________________________________
calendarserver-changes mailing list
[EMAIL PROTECTED]
http://lists.macosforge.org/mailman/listinfo/calendarserver-changes

_______________________________________________
calendarserver-dev mailing list
calendarserver-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo/calendarserver-dev

Reply via email to