Updated Branches:
  refs/heads/master beb946053 -> 85aa740c9

[CB-481] Removed todo comment introduced by bryce, clarified what is going on


Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/commit/85aa740c
Tree: 
http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/tree/85aa740c
Diff: 
http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/diff/85aa740c

Branch: refs/heads/master
Commit: 85aa740c9864881db562bb1f1fcf672531fea8b1
Parents: beb9460
Author: Fil Maj <[email protected]>
Authored: Wed Jul 11 09:35:29 2012 -0700
Committer: Fil Maj <[email protected]>
Committed: Wed Jul 11 09:35:29 2012 -0700

----------------------------------------------------------------------
 framework/src/org/apache/cordova/App.java |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/blob/85aa740c/framework/src/org/apache/cordova/App.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/App.java 
b/framework/src/org/apache/cordova/App.java
index 1481624..dbc8909 100755
--- a/framework/src/org/apache/cordova/App.java
+++ b/framework/src/org/apache/cordova/App.java
@@ -48,7 +48,10 @@ public class App extends Plugin {
             if (action.equals("clearCache")) {
                 this.clearCache();
             }
-            else if (action.equals("show")) { // TODO @bc - Not in master 
branch.  When should this be called?
+            else if (action.equals("show")) {
+                // This gets called from JavaScript onCordovaReady to show the 
webview.
+                // I recommend we change the name of the Message as 
spinner/stop is not
+                // indicative of what this actually does (shows the webview).
                 cordova.getActivity().runOnUiThread(new Runnable() {
                     public void run() {
                         webView.postMessage("spinner", "stop");

Reply via email to