Simon Thanks or the quick response. I will check the iOS code jut in case. For now, without going to full redesign (which may add more bugs), I think this is clearly a bug that can be quickly fixed: The lazy way as I did by adding a no-op around the dismiss dialog Maybe have a check on the dialog and see of it null (on dismissal should be set to null)
If this change cannot be added, it is ok but I would rather not differ too much from the Code base Olivier On Jan 30, 2012, at 13:23, Simon MacDonald <simon.macdon...@gmail.com> wrote: > Yeah, I never got a chance to write back. Here are the quick hits. > > 1) We had to do a fix with back button functionality so your code doesn't > merge clean now. > 2) The same functionality is not available on BB, WP7 and we usually like > to have the same functionality across platforms. > 3) Joe is working on a big change for 1.5. > > Taking all this into consideration we are going to hold off merging your > changes for 1.4 and take a closer look at it for 1.5 and see if we can make > it cross platform. > > Sound good? > > Simon Mac Donald > http://hi.im/simonmacdonald > > > On Mon, Jan 30, 2012 at 4:16 PM, Olivier Brand <oliv...@passbox.com> wrote: > >> Simon, >> >> Never got feedback on my pull req >> >> >> Olivier >> >> On Jan 30, 2012, at 13:11, Simon MacDonald <simon.macdon...@gmail.com> >> wrote: >> >>> Okay, I updated the Android repo with version 1.4.0 and tagged the >> change. >>> Steve, if you are reading this don't forget to pick up the new >> plugins.xml >>> file to put into the .zip download. >>> >>> Simon Mac Donald >>> http://hi.im/simonmacdonald >>> >>> >>> On Fri, Jan 27, 2012 at 12:08 PM, Simon MacDonald < >> simon.macdon...@gmail.com >>>> wrote: >>> >>>> Because sometimes there isn't enough coffee, I forgot to update the >>>> version file so I delete and re-tagged the Android repo just now. >>>> >>>> Simon Mac Donald >>>> http://hi.im/simonmacdonald >>>> >>>> >>>> On Thu, Jan 26, 2012 at 2:20 PM, Simon MacDonald < >>>> simon.macdon...@gmail.com> wrote: >>>> >>>>> Android has been tagged 1.4.0rc1. >>>>> >>>>> Simon Mac Donald >>>>> http://hi.im/simonmacdonald >>>>> >>>>> >>>>> >>>>> On Thu, Jan 26, 2012 at 1:46 PM, Steven Gill <stev...@adobe.com> >> wrote: >>>>> >>>>>> That sounds about right. Tag 1.4.0 on Monday and release Tuesday. >>>>>> >>>>>> -Steve >>>>>> >>>>>> On 12-01-26 10:35 AM, "Simon MacDonald" <simon.macdon...@gmail.com> >>>>>> wrote: >>>>>> >>>>>>> Are we tagging 1.4.0rc1? Then is the plan to tag 1.4.0 on Monday if >> no >>>>>>> show >>>>>>> stoppers are found? >>>>>>> >>>>>>> Simon >>>>>>> On Jan 26, 2012 1:23 PM, "Brian LeRoux" <b...@brian.io> wrote: >>>>>>> >>>>>>>> woo >>>>>>>> >>>>>> >>>>>> >>>>> >>>> >>
