Hey I know that I should have commented on this earlier before it arrived in master, but instead of calling the interface CordovaActivity, can we call it CordovaInterface, since in the future it won't always be an Activity? That's so that we can ease CordovaWebView in Cordova 1.6. I did a dry run of the rebase today to see what was going to happen with the CordovaWebView stuff after the rename, and this was the main thing that I ran into. I'm willing to make the change and commit it if everyone's cool with that.
Joe On Mon, Feb 6, 2012 at 7:40 AM, Simon MacDonald <simon.macdon...@gmail.com>wrote: > com.phonegap.api is back now after a bit more testing was done. > > > https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=commit;h=d8d7c29afe78ae4408b7e95a7225515e2813e9f3 > > Simon Mac Donald > http://hi.im/simonmacdonald > > > On Fri, Feb 3, 2012 at 12:29 PM, Simon MacDonald > <simon.macdon...@gmail.com>wrote: > > > I'm going to add com.phonegap.api back into the repository after > > lunch. That way plugins won't be completely screwed. If we eventually > > find out that it needs to be pulled out we can cross that bridge once > > we get to it. > > > > Simon Mac Donald > > http://hi.im/simonmacdonald > > > > > > > > On Fri, Feb 3, 2012 at 11:26 AM, Simon MacDonald > > <simon.macdon...@gmail.com> wrote: > > > Yeah, it would totally screw over phonegap-plugins. That's why I want > > > to get confirmation on whether or not we can keep them around. > > > > > > Simon Mac Donald > > > http://hi.im/simonmacdonald > > > > > > > > > > > > On Fri, Feb 3, 2012 at 11:23 AM, Drew Walters <deedu...@gmail.com> > > wrote: > > >> Just to be clear......not maintaining some of the key old classes > > (IPlugin, > > >> PhoneGapExtension, etc.) will cause all plugins on phonegap-plugins to > > >> require a refactor right? > > >> > > >> For the BlackBerry changes, I was trying to maintain the classes used > by > > >> plugins by changing them to extend the Cordova version. It was > working > > >> well till I hit the JSON classes which throw JSON exceptions from the > > >> constructors, thereby screwing me. > > >> > > >> On Fri, Feb 3, 2012 at 9:54 AM, Simon MacDonald > > >> <simon.macdon...@gmail.com>wrote: > > >> > > >>> Commited: > > >>> > > >>> > > >>> > > > https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=commit;h=664a061d10e2db79e05a0c5e2a1b5afe5e76d08b > > >>> > > >>> Simon Mac Donald > > >>> http://hi.im/simonmacdonald > > >>> > > >>> > > >>> > > >>> On Thu, Feb 2, 2012 at 4:02 PM, Brian LeRoux <b...@brian.io> wrote: > > >>> > Sounds good Simon, lmk when you land that commit and I'll start > > testing > > >>> trmw. > > >>> > > > >>> > On Thu, Feb 2, 2012 at 12:53 PM, Simon MacDonald > > >>> > <simon.macdon...@gmail.com> wrote: > > >>> >> Well I think my branch is ready to go in now. Testing has gone > well > > >>> >> and I'd prefer to get this into the repo earlier rather than later > > in > > >>> >> order to shake out any issues before we get ready to ship 1.5.0 on > > >>> >> February 27th. If we are going to hold that date it only gives us > > >>> >> three weeks before we go live and we probably should code freeze > > >>> >> before that as we have major changes planned including: > > >>> >> > > >>> >> * PhoneGap -> Apache Cordova name change > > >>> >> * CordovaView > > >>> >> * Cordova-JS > > >>> >> > > >>> >> So if there are no major objections I'd like to commit my change > > >>> >> tomorrow so we can have more soak time. > > >>> >> > > >>> >> Also, I took a stab as making all the necessary changes to > > android/bin > > >>> >> but if you can test it that would be fantastic. > > >>> >> > > >>> >> Simon Mac Donald > > >>> >> http://hi.im/simonmacdonald > > >>> >> > > >>> >> > > >>> >> > > >>> >> On Thu, Feb 2, 2012 at 3:38 PM, Brian LeRoux <b...@brian.io> wrote: > > >>> >>> Bryce/Simon: > > >>> >>> > > >>> >>> re docs: Apache Cordova seems like the right thing to do but we > > should > > >>> >>> wait until the unified js is merged into the respective projects > to > > >>> >>> see just how that effects things. (eg: cordova.js) > > >>> >>> > > >>> >>> re android /bin: I'll hit that. > > >>> >>> > > >>> >>> > > >>> >>> > > >>> >>> On Wed, Feb 1, 2012 at 5:50 PM, Simon MacDonald > > >>> >>> <simon.macdon...@gmail.com> wrote: > > >>> >>>> You can see the Android rename at: > > >>> >>>> > > >>> >>>> https://github.com/macdonst/cordova-android/tree/rename > > >>> >>>> > > >>> >>>> so far it looks good. I've run through the mobile spec app and > the > > >>> >>>> automated tests pass at the same rate and the manual tests are > > fine as > > >>> >>>> well. I will run though some real device testing tomorrow. > > >>> >>>> > > >>> >>>> The one area I'm sketchy on is the ./bin scripts as I haven't > been > > >>> >>>> using them very much. I'd like to get some assistance on that > > side of > > >>> >>>> things. > > >>> >>>> > > >>> >>>> Simon Mac Donald > > >>> >>>> http://hi.im/simonmacdonald > > >>> >>>> > > >>> >>>> > > >>> >>>> > > >>> >>>> On Wed, Feb 1, 2012 at 4:54 PM, Bryce Curtis < > > curtis.br...@gmail.com> > > >>> wrote: > > >>> >>>>> Now that 1.4.1 is tagged (or almost) we need to discuss 1.5.0. > I > > >>> would > > >>> >>>>> suggest the first task is to do the name change to cause > minimal > > >>> impact and > > >>> >>>>> give time to verify code & update docs. > > >>> >>>>> > > >>> >>>>> The changes are in 3 areas: > > >>> >>>>> 1. Native code - com.phonegap packages change to > > org.apache.cordova, > > >>> >>>>> directories > > >>> >>>>> 2. JS code - what does PhoneGap global change to? Cordova? > > >>> >>>>> 3. docs - do we refer to it as Apache Cordova everywhere or > just > > the > > >>> first > > >>> >>>>> time and use Cordova after that? > > >>> >>>>> > > >>> >>>>> Once we decide what words to use, Simon and Drew have > > volunteered to > > >>> do > > >>> >>>>> Android and Blackberry. > > >>> > > >
