I will commit later tonight. Family function at 7pm our time so busy right now.
Simon Mac Donald http://hi.im/simonmacdonald On Mon, Feb 27, 2012 at 4:40 PM, Filip Maj <[email protected]> wrote: > Simon: make the change. Cordova-js is not integrated into BB yet so it may > be a breaking change but Tim and Gord should take a look at it and make > the necessary change. > > I agree with the change overall. Native returns a string that defines the > type of connection. Let's get the other native platforms lined up with > this and it won't be an issue. > > Tim, can you please take a note of this and add it to your BlackBerry <-> > cordova-js integration todo list? > > On 12-02-27 1:20 PM, "Simon MacDonald" <[email protected]> wrote: > >>Hey, >> >>The current version of common JS has a bug where >>navigator.network.connection.type is always undefined and the >>online/offline events never fire. I have a fix for it here: >> >>https://github.com/macdonst/callback-js/commit/32d2426aac7d468f59036ecff35 >>b15810071a34d >> >>but that will probably break BlackBerry. We need to come together on a >>common way to do this before we release 1.5. I will talk to Becky and Drew >>about it but I just wanted other to know there is a problem. >> >>Simon Mac Donald >>http://hi.im/simonmacdonald >
