+1 for restructure of cordova-js. One issue that I see as unnecessary and a source of error is checking in cordova.android.js into the android repository. As developers we already have to be able to build cordova-js and then copy it under the platform. So, any change to cordova-js also requires a corresponding check-in to each of the platform repositories. Right now that's only Android, but as the rest move to cordova-js, it will be iOS, BB, WP7, bada, ... - well, you get the idea. I suggest we only do the merge when packaging up a release.
On Tue, Feb 28, 2012 at 11:09 AM, Patrick Mueller <[email protected]> wrote: > On Tue, Feb 28, 2012 at 12:00, Filip Maj <[email protected]> wrote: > > > Yeah I like it overall. I'll file it in JIRA and set it up for post-1.5. > > > > I am not sure I like the index.js thing but I don't know why ;) > > > Honestly, not a big fan of <name>/index.js matching "name"; but let's see; > the index.js thing is one of the conventions of node ... > > -- > Patrick Mueller > http://muellerware.org >
