We should run bin/create which does run ant/jar. I think we should have a QA step to make sure this script works and not leave everything to automation.
On Fri, Apr 13, 2012 at 1:43 PM, Simon MacDonald <[email protected]>wrote: > I just updated the build.xml so the version in that file is updated > automatically. For anyone who cares this is how you prepare to tag > cordova-android. > > 1) edit the VERSION file with the new version number. > 2) Run "ant jar" > 3) Create a new commit adding the files: > > VERSION > bin/templates/project/cordova/templates/project/assets/www/index.html > framework/assets/www/index.html > framework/src/org/apache/cordova/Device.java > > 4) tag the new version > > git tag -a {version} -m '{version}' > > 5) Push the commit and tag > > git push cordova master > git push --tags cordova master > > Hmmm...I should probably write a script for this but instead I'm off > to take my family to supper. > > Simon Mac Donald > http://hi.im/simonmacdonald > > > > On Fri, Apr 13, 2012 at 4:19 PM, Joe Bowser <[email protected]> wrote: > > OK, saw that change. I updated index.html, since we weren't adding the > .js > > at the end for some unknown reason. I also updated the checklist on the > > wiki so we run the bin/create script instead of ant. If we're following > > that, we should catch stupid mistakes such as this. > > > > Also, who is not in a bad mood? > > > > On Fri, Apr 13, 2012 at 12:42 PM, Simon MacDonald < > [email protected] > >> wrote: > > > >> I'm about to push up a change to the android "bin/create" script. That > >> script calls "bin/templates/project/cordova/create" which in turn > >> expects the files: > >> > >> bin/templates/project/cordova/templates/project/res/xml/cordova.xml > >> bin/templates/project/cordova/templates/project/res/xml/plugins.xml > >> > >> to be hanging around. This is what caused the bug in 1.6.0 as they > >> were not up to date. Since I'm a firm believer that source code > >> control should only have one copy of any given file I've modified the > >> scripts so they go get cordova.xml and plugins.xml from their > >> canonical locations in "framework/res/xml". > >> > >> I think the benefits are obvious. > >> > >> Simon Mac Donald > >> http://hi.im/simonmacdonald > >> > >> P.S. Yes, I am in a bad mood. > >> > >> On Fri, Apr 13, 2012 at 3:26 PM, Joe Bowser <[email protected]> wrote: > >> > OK, It's clear we're not deleting the directory, and we have people > who > >> > care about this. I'm going to be bumping up priority on the build > >> scripts, > >> > since they've proven to be higher. That's pretty much what I wanted > out > >> of > >> > this thread. > >> > > >> > On Fri, Apr 13, 2012 at 10:19 AM, Brian LeRoux <[email protected]> wrote: > >> > > >> >> > Now, an XML file in these scripts have caused 1.6.1 to exist, which > >> has > >> >> now > >> >> > been extended to Monday, > >> >> > >> >> Thats ok. Bugs manifest. A point release, while a pain in the ass, > >> >> isn't the end of the world and a part of doing things right by our > >> >> users. > >> >> > >> >> > >> >> > and have thrown the release schedule out of whack > >> >> > >> >> I do not think it has to. > >> >> > >> >> > >> >> > such that it looks like I'll have to delay CordovaWebView to 1.8 > >> because > >> >> it > >> >> > probably won't be ready by the end of the month. > >> >> > >> >> Thats ok too. Lets work towards it and get it done when its ready to > >> >> ship. Let go of the attachment to a particular date and focus that > >> >> quiet rage on the code you want rather than a particular date. > >> >> > >> >> > >> >> > I don't think moving this into ant is a good idea, > >> >> > >> >> Me either. But wanted to know how you'd approach it. Also: I take > >> >> exception to your assertion that Bash is, or ever has been, a flavor > >> >> of the month. ;) (And ya I remember the Ruby, then jRuby, then > Python, > >> >> and then Node attempts.) > >> >> > >> >> > >> >> > and these helper scripts belong in some tooling repository separate > >> from > >> >> the Cordova project. > >> >> > >> >> I disagree but only b/c ppl still use Cordova projects stand alone > >> >> instead of simultaneously for all platforms. View this a stepping > >> >> stone to a future where that master script finally comes to fruition. > >> >> > >> >
