I think having the built js file in each platform is fine, and it should just be checked in before tagging/releasing. Otherwise both repos have to be in perfect sync at all times.
I see this as a slippery slide towards submodules, which we already determined are a bad idea. The more inter-dependencies we create in these repos, the more we have to move in lock-step. Some autonomy in each repo is IMHO a good thing, and the train gets hitched monthly anyway when we release. I think, at any point in time, developers should be able to go to any platform repo, download and build and have a working build. Cheers, Jesse Sent from my iPhone5 On 2012-04-13, at 7:00 PM, Filip Maj <[email protected]> wrote: > So essentially no more .js file in the native repos? > > We would need to update the READMEs and point users to the cordova-js repo > so they can build it themselves too then ya? > > On 4/13/12 3:11 PM, "Anis KADRI" <[email protected]> wrote: > >> +1 >> >> On Fri, Apr 13, 2012 at 3:07 PM, Shazron <[email protected]> wrote: >> >>> +1 >>> >>> On Fri, Apr 13, 2012 at 1:39 PM, Drew Walters <[email protected]> >>> wrote: >>>> +1 for this and all the other times it has been mentioned. >>>> >>>> On Fri, Apr 13, 2012 at 3:35 PM, Joe Bowser <[email protected]> wrote: >>>>> +1, but I'm in the same boat as Simon. >>>>> >>>>> On Fri, Apr 13, 2012 at 1:31 PM, Simon MacDonald >>>>> <[email protected]>wrote: >>>>> >>>>>> Hey, >>>>>> >>>>>> I've been looking at the coho build release script today and one >>> area >>>>>> I think we should enhance is for the script to build the common JS >>> and >>>>>> then have the native components pick up the JS once it is built. >>> This >>>>>> would reduce the dependency of having the repo owner have to build >>> the >>>>>> common JS then commit it to the platform repo, then tag their repo. >>>>>> Instead you just tag all the repos and have someone run the coho >>>>>> script to create all the deliverables. Since I'm only very familar >>>>>> with the Android build I've done the change for it only. Is it >>>>>> possible, desirable, to do the same for other platforms? >>>>>> >>>>>> Here is my change: >>>>>> >>>>>> >>>>>> >>> >>> https://github.com/macdonst/coho/commit/2bb57c3bc8172afd2101bc58224c9b8e9 >>> f9680ed >>>>>> >>>>>> Questions? Comments? Quemments? >>>>>> >>>>>> Simon Mac Donald >>>>>> http://hi.im/simonmacdonald >>>>>> >>> >
