[
https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265886#comment-13265886
]
Filip Maj edited comment on CB-298 at 5/1/12 4:22 PM:
------------------------------------------------------
Instead of [clobbering on the window.PhoneGap and window.Cordova objects inside
the cordova.js
module|https://github.com/apache/incubator-cordova-js/blob/master/lib/cordova.js#L280-L285],
we can add those two to the common platform definition .js file and mimic the
{{window.cordova}} object.
Basically copy/paste [lines 3 to 10 in
common.js|https://github.com/apache/incubator-cordova-js/blob/master/lib/common/common.js#L3-L10]
and change {{cordova}} to {{Cordova}} and {{PhoneGap}}.
Shaz can you take care of this? I'm away at conference and don't have much time
at the moment.
was (Author: filmaj):
Instead of clobbering on the {{window.PhoneGap}} and {{window.Cordova}}
objects inside the cordova.js module, we can add those two to the common
platform definition .js file and mimic the {{window.cordova}} object.
Basically copy/paste [lines 3 to 10 in
common.js|https://github.com/apache/incubator-cordova-js/blob/master/lib/common/common.js#L3-L10]
and change {{cordova}} to {{Cordova}} and {{PhoneGap}}.
Shaz can you take care of this? I'm away at conference and don't have much time
at the moment.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform
> definition, which get dropped onto the `window` object: `plugins` and
> `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
