[ 
https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266000#comment-13266000
 ] 

Filip Maj commented on CB-298:
------------------------------

Sorry, I'm confused. I thought we 
[reverted|http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=blobdiff;f=lib/cordova.js;h=5050f8cb8be92658dbe8049ae9c77f22ab34eedb;hp=d3da4815a69f3312fd8c5c35715df599a059983d;hb=b2bfa321b4b9c952d8977baec786996a745c127d;hpb=cb7a4c7a4a680eccaef768a2e0c6e4631d39fcaf]
 the [commit to add deprecation 
notices|http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=commit;h=b80ff3407ee5de1736b26fd2f82a96c2dd8d34c5]
 to all functions (except {{exec}}) because we found that {{exec}} was not 
defined on the old {{PhoneGap}} and {{Cordova}} globals?

Although I don't think CB-560 has anything to do with the above two commits. 
That is, the last reversion should _not_ fix CB-560.
                
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
>                 Key: CB-298
>                 URL: https://issues.apache.org/jira/browse/CB-298
>             Project: Apache Callback
>          Issue Type: Improvement
>          Components: CordovaJS
>    Affects Versions: 1.4.0, 1.5.0, 1.6.0
>            Reporter: Filip Maj
>            Assignee: Shazron Abdullah
>            Priority: Minor
>              Labels: api-change, javascript
>             Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform 
> definition, which get dropped onto the `window` object: `plugins` and 
> `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to