[ 
https://issues.apache.org/jira/browse/CB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274745#comment-13274745
 ] 

Filip Maj commented on CB-462:
------------------------------

The JS for this work is all done here: 
http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=shortlog;h=refs/heads/462
                
> Refactor accelerometer JS <-> native interactions
> -------------------------------------------------
>
>                 Key: CB-462
>                 URL: https://issues.apache.org/jira/browse/CB-462
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaJS
>    Affects Versions: 1.6.0
>            Reporter: Filip Maj
>            Assignee: Filip Maj
>             Fix For: 1.8.0
>
>
> Similar to CB-359.
> We use a completely different set of native actions to control Geolocation, 
> Accelerometer and Compass sensor APIs. These all have identical APIs and 
> really should be implemented in the same way.
> For accelerometer, there is no reason to need a {{setTimeout}} and 
> {{getTimeout}} native action.
> Should use the pattern employed in CB-359 to implement the accel sensor API.
> CordovaJS should also be wrapping the error and success callbacks in 
> {{accelerometer}} calls and making sure the right {{Acceleration}} and 
> {{Error}} objects are passed to the user callbacks. Also need to add more 
> unit tests to CordovaJS to be testing for all of this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to